[#FILEUPLOAD-66] DefaultFileItem issues

Commons FileUpload

DefaultFileItem issues

Created: 11/Mar/03 08:57 PM Updated: 09/Mar/07 08:32 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	patch.txt	2003-04-02 12:10 AM	Ernie Argetsinger	2 kB

Environment:

« Hide

Operating System: All
Platform: Other

Bugzilla Id:

17872

Description

« Hide

DefaultFileItem uses "/" instead of File.separator in newInstance(...).
Additionally, (path != null) should be required in addition to the
(requestSize > threshold) condition before attempting to create a
temporary File for the upload data. A feature enhancement would be
to create temporary files only for file upload data.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Ernie Argetsinger added a comment - 02/Apr/03 12:10 AM

Created an attachment (id=5587)
DefaultFileItem changes, null check, exception

[ Permlink | « Hide ]

Ernie Argetsinger added a comment - 02/Apr/03 12:15 AM

Added a patch to address File.separator, null path issues. Throws an exception
if the path is null. Alternative to exception approach would be to use
File.createTempFile method. Not sure which way the committers want to go.

[ Permlink | « Hide ]

David Graham added a comment - 02/Apr/03 12:28 AM

Why was "throws Exception" added to the method signature? You're throwing a
RuntimeException so you don't need to declare it in the signature.

[ Permlink | « Hide ]

Martin Cooper added a comment - 02/Apr/03 04:58 AM

Fixes to these issues already exist in the modified code base I am in the
process of finishing up.

[ Permlink | « Hide ]

Martin Cooper added a comment - 28/Apr/03 07:10 AM

Fixed in the 20030428 nightly build.