[fileupload] Memory Issue

• Key: FILEUPLOAD-59
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Vimil Saju
• Affects Version/s: 1.0 Final

Environment

Operating System: All
Platform: All

Description

The reason for out of memory exception is that a FileItem object is created for
each request parameter whether it is file or an ordinary string parameter. the
FileItem object has a field of type DeferredFileStream which is initialized to
262144 bytes (256 Kb) so if there are around 1000 request parameters, around
256 MB of space will be required to hold the request parameters even though
most parameters may require only 8 to 10 bytes of memory for storage.

Comments

[Martin Cooper]

This was fixed some time ago in 1.1-dev.

[Felix K F Chan]

I could not find any release related to this change in fileupload.

[Jochen Wiedmann]

Apart from possible changes, a streaming API was added in 1.2. If you are sensitive for memory considerations, this is the way to go anyways.

[Felix K F Chan]

Since I am using Struts v1.1, when even there is multipart/form-data request, it use fileupload v1.0. I am not sure if I put fileupload v1.2 together with Struts v1.1, will they work.

I notice the code in fileupload v1.2 has changed FileUploadBase to use streaming, but will it save some memory for form fields in the case mentioned in this issue?

[Jochen Wiedmann]

I see absolutely no reason, why we should still support 1.1. This applies, in particular, to memory considerations and stuff like that. The streaming API was invented exactly for that purpose.

[Felix K F Chan]

It looks like that fileupload v1.2 plus io v1.31 should solve the problem.

[Purushottam M. Nawle]

Attached is the zip file containing a sample application using commons file upload. The lib directory contains a jar file named "commons-fileupload-ext.jar" resolves the out of memory problem. The new version of FileItem treats the plain text form parameters and multipart parameter in different ways. The newer version uses StringBuffer for the plain text parameters. This FileItem also supports ajax based monitoring of the file upload.

[Purushottam M. Nawle]

Along with this the jar provides a base servlet class which does the file uploading. The user needs to extend this class to add just business logic such as implementing validation, process the uploaded file etc.

[vaishali dolas]

I'm using the jar which are given in above zip.When i'm trying to run the same application in struts2 its giving problem for small file upload.
If file size is small it not uploading.

Please don't use this bug tracker for support requests. Your best bet seems to be the Struts users mailing list.

Apart from that, your problem might be related to FILEUPLOAD-138. If so, it should be fixed by upgrading to fileupload 1.2.1.