[FILEUPLOAD-251] DiskFileItem#getTempFile() is broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.4
• Assignee: Unassigned
• Reporter: Sebb
• Created: 17/Feb/14 00:53
• Updated: 05/Feb/19 14:11
• Resolved: 17/Feb/14 02:22

Description

DiskFileItem#getTempFile() looks wrong.

Presumably the intention of providing the protected method was to allow the generation of the path name to be overwritten. This can indeed be done.

However, if this is done, the tempFile variable will not be set up, so the path name won't be cached - unless the overriding method also caches the name.

The file name needs to agree with the DeferredFileOutputStream that is created. This is implied in the Javadoc, but is not currently enforced.

The protected method needs to implement the name generation part only.