[fileupload] FileUpload 2 gig File Size Limitation

• Key: FILEUPLOAD-102
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Jochen Wiedmann
• Reporter: Sharmarke Aden
• Affects Version/s: 1.1 Final
• Fix Version/s: 1.2

Environment

Operating System: All
Platform: All

Description

Looking through the FileUpload 1.1 code it looks like there is a limitation on
how big of a file can be received and processed. If you look at the readBodyData
method of the MultipartStream class you'll notice that an integer is being used
to keep a tally of the total number of bytes received when processing an
encapsulation. I recommend changing the type of the variable "total" to a long
in the readBodyData and wherever a tally of bytes received is done.

Comments

[Martin Cooper]

It's not quite that simple. The content length provided by the container (either
servlet or portlet) is also an integer, so there is a limitation in the
containers themselves. (See Request.getContentLength and
ActionRequest.getContentLength.)

[Sharmarke Aden]

Created an attachment (id=17461)
total variable type changed from int to long

Here is a patch that that resolves the limitation (I think). This patch simply
changes type of the total variable from int to long.

[Sharmarke Aden]

(In reply to comment #1)
> It's not quite that simple. The content length provided by the container (either
> servlet or portlet) is also an integer, so there is a limitation in the
> containers themselves. (See Request.getContentLength and
> ActionRequest.getContentLength.)

Wow, I guess I never noticed that that Request.getContentLength returns an
integer. Still, the spec allows for getContentLength to return -1 (unknown
length) therefore the length of the content sent can be greater than 2 gig.

[Jochen Wiedmann]

1.2 allows to set the limit to -1 (aka no limit), in which case the file size is unlimited.