[EXEC-55] Set names for started threads

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1
• Fix Version/s: 1.2
• Assignee: Siegfried Goeschl
• Reporter: Dominik Stadler
• Created: 17/Feb/11 15:41
• Updated: 28/Dec/13 18:21
• Resolved: 08/Oct/11 20:11

Description

Currently some threads are started without names, this makes it harder to read thread dumps, especially in large applications with many threads.

The following patch fixes this for the places that I could identify:

### Eclipse Workspace Patch 1.0
#P commons-exec-trunk
Index: src/main/java/org/apache/commons/exec/DefaultExecutor.java
===================================================================
--- src/main/java/org/apache/commons/exec/DefaultExecutor.java	(revision 1071645)
+++ src/main/java/org/apache/commons/exec/DefaultExecutor.java	(working copy)
@@ -181,7 +181,7 @@
             throw new IOException(workingDirectory + " doesn't exist.");
         }
 
-        executorThread = new Thread() {
+        executorThread = new Thread("Default Executor") {
             public void run() {
                 int exitValue = Executor.INVALID_EXITVALUE;
                 try {                    
Index: src/main/java/org/apache/commons/exec/PumpStreamHandler.java
===================================================================
--- src/main/java/org/apache/commons/exec/PumpStreamHandler.java	(revision 1071645)
+++ src/main/java/org/apache/commons/exec/PumpStreamHandler.java	(working copy)
@@ -284,7 +284,7 @@
     protected Thread createPump(final InputStream is, final OutputStream os,
             final boolean closeWhenExhausted) {
         final Thread result = new Thread(new StreamPumper(is, os,
-                closeWhenExhausted));
+                closeWhenExhausted), "Stream Pumper");
         result.setDaemon(true);
         return result;
     }
@@ -300,7 +300,7 @@
      */
     private Thread createSystemInPump(InputStream is, OutputStream os) {
         inputStreamPumper = new InputStreamPumper(is, os);
-        final Thread result = new Thread(inputStreamPumper);
+        final Thread result = new Thread(inputStreamPumper, "Input Stream Pumper");
         result.setDaemon(true);
         return result;
     }