Better error message in MultiPartEmail.attach()

• Key: EMAIL-78
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Siegfried Goeschl
• Reporter: Aaron Digulla
• Affects Version/s: 1.1
• Fix Version/s: 1.2

Description

Please replace line 367 of org.apache.commons.mail.MultiPartEmail

[code]
throw new EmailException("Invalid URL set");
[code]

with

[code]
throw new EmailException("Invalid URL: "+url, e);
[code]

to generate a better error message when an IOException is thrown.

Comments

[Corey Scott]

Re-throws exceptions as appropriate

[Siegfried Goeschl]

Hi Corey, any reason why not to pass the invalid URL parameter into the exception msg?

[Siegfried Goeschl]

Applied the patch and added the URL parameter to the exception message.

[Corey Scott]

Nope, I cant think of a reason why I didnt pass it. Thanks for catching and fixing this.