[DRILL-6960] Auto Limit Wrapping should not apply to non-select query

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Duplicate
• Affects Version/s: 1.16.0
• Fix Version/s: 1.16.0
• Component/s: Web Server
• Labels: doc-impacting user-experience
• Assignee: Kunal Khatua
• Reporter: Kunal Khatua
• Reviewer: Vova Vysotskyi
• Due: 31/Jan/19
• Created: 09/Jan/19 23:07
• Updated: 04/Apr/19 18:52
• Resolved: 04/Apr/19 18:49

Description

IhorHuzenko pointed out that DRILL-6050 can cause submission of queries with incorrect syntax.
For example, when user enters SHOW DATABASES' and after limitation wrapping SELECT * FROM (SHOW DATABASES) LIMIT 10 will be posted.
This results into parsing errors, like:
Query Failed: An Error Occurred org.apache.drill.common.exceptions.UserRemoteException: PARSE ERROR: Encountered "( show" at line 2, column 15. Was expecting one of: <IDENTIFIER> ... .

The fix should involve a javascript check for all non-select queries and not apply the LIMIT wrap for those queries.

Issue Links

• is caused by: DRILL-6050 Provide a limit to number of rows fetched for a query in UI
• is required by: DRILL-7048 Implement JDBC Statement.setMaxRows() with System Option
• links to: GitHub Pull Request #1608