[DRILL-6253] HashAgg Unit Testing And Refactoring

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: Future
• Assignee: Timothy Farkas
• Reporter: Timothy Farkas
• Reviewer: Boaz Ben-Zvi
• Created: 15/Mar/18 20:50
• Updated: 04/Jan/19 22:02

Description

This is a parent issue to hold all the subtasks required to refactor HashAgg to make it unit testable. Design doc

https://docs.google.com/document/d/110BAWg3QXMfdmuqB0p3HuaoKpPGY-lqCRtHFxdh53Ds/edit?usp=sharing

Issue Links

• supercedes: DRILL-6032 Use RecordBatchSizer to estimate size of columns in HashAgg

Sub-Tasks

• Add Basic Data Correctness Unit Tests: Resolved
• Enhance OperatorTestBuilder to use RowSets instead of adhoc json strings.: Resolved
• Moving Common Spilling Code Into a Seperate Utility: Resolved
• Simplify Usage of OperatorPhase in HashAgg Template: Resolved
• Start moving code for handling a partition in HashAgg into a separate class: Open
• Move code for evicting a partition in HashAgg into a separate class: In Progress
• Simplify logging statements in HashAgg: Open