[DRILL-5832] Migrate OperatorFixture to use SystemOptionManager rather than mock

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.12.0
• Fix Version/s: 1.12.0
• Labels: ready-to-commit
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Reviewer: Timothy Farkas
• Created: 02/Oct/17 19:52
• Updated: 13/Nov/17 14:12
• Resolved: 13/Nov/17 14:12

Description

The OperatorFixture provides structure for testing individual operators and other "sub-operator" bits of code. To do that, the framework provides mock network-free and server-free versions of the fragment context and operator context.

As part of the mock, the OperatorFixture provides a mock version of the system option manager that provides a simple test-only implementation of an option set.

With the recent major changes to the system option manager, this mock implementation has drifted out of sync with the system option manager. Rather than upgrading the mock implementation, this ticket asks to use the system option manager directly – but configured for no ZK or file persistence of options.

The key reason for this change is that the system option manager has implemented a sophisticated way to handle option defaults; it is better to leverage that than to provide a mock implementation.

Issue Links

• contains: DRILL-5833 Parquet reader fails with assertion error for Decimal9, Decimal18 types
• relates to: DRILL-5855 Provide a useful error message when the SystemOptionManager is queried for a non-existent option
• links to: GitHub Pull Request #970