[DRILL-5723] Support System/Session Internal Options And Additional Option System Fixes

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.12.0
• Labels: doc-impacting ready-to-commit
• Assignee: Timothy Farkas
• Reporter: Timothy Farkas
• Reviewer: Paul Rogers
• Created: 15/Aug/17 22:45
• Updated: 11/Oct/18 15:16
• Resolved: 27/Sep/17 17:55

Description

This is a feature proposed by ben-zvi.

Currently all the options are accessible by the user in sys.options. We would like to add internal options which can be altered, but are not visible in the sys.options table. These internal options could be seen by another alias select * from internal.options. The intention would be to put new options we weren't comfortable with exposing to the end user in this table.

After the options and their corresponding features are considered stable they could be changed to appear in the sys.option table.

A bunch of other fixes to the Option system have been clubbed into this:

• OptionValidators no longer hold default values. Default values are contained in the SystemOptionManager
• Options have an OptionDefinition. The option definition includes:
• A validator
• Metadata about the options visibility, required permissions, and the scope in which it can be set.
• The Option Manager interface has been cleaned up so that a Type is not required to be passed in in order to set and delete options

Issue Links

• causes: DRILL-6790 Updating SET and ALTER SYSTEM doc pages
• contains: DRILL-3363 Give user exception when users are trying to set system-wide-variable with "alter session set"
• is related to: DRILL-6668 In Web Console, highlight options that are different from default values
• links to: GitHub Pull Request #923