Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-5171

TestSort unit test tests the external sort, not the in-memory SortBatch

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.8.0
    • None
    • None
    • None

    Description

      Drill provides two sort operators: an in-memory SortBatch and a spillable ExternalSortBatch. The external sort is adaptive: it sorts in memory when it can, and spills when necessary. Perhaps for this reason, the in-memory sort appears to be deprecated (but is not marked as such.)

      The in-memory sort has associated test case: TestSort and TestSimpleSort. When run, TestSort actually uses the external sort. TestSimpleSort has a single test case which is disabled.

      The result is that no tests exist for the in-memory sort. That operator should be marked as deprecated, or the test cases adjusted to actually exercise the in-memory sort operator.

      Attachments

        Activity

          People

            paul-rogers Paul Rogers
            paul-rogers Paul Rogers
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: