[DRILL-5151] ConventionTraitDef.plannerConversionMap is not thread safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Query Planning & Optimization
• Assignee: Chunhui Shi
• Reporter: Chunhui Shi
• Created: 22/Dec/16 00:46
• Updated: 22/Dec/17 22:33
• Resolved: 22/Dec/17 22:33

Description

We are using static instance ConventionTraitDef.INSTANCE globally and plannerConversionMap(class WeakHashMap) defined in ConventionTraitDef class is not threadsafe. And the data in the map could corrupt and cause dead loop or other data error.

private final WeakHashMap<RelOptPlanner, ConversionData>
plannerConversionMap =
new WeakHashMap<RelOptPlanner, ConversionData>();