Details
-
Bug
-
Status: Resolved
-
Minor
-
Resolution: Won't Fix
-
None
-
None
-
None
Description
The enums DataMode and MinorType (in Types.proto) each contain a value (OPTIONAL and NULL respectively) that generate into problematic C++ code on Windows under Visual Studio.
I propose to add a prefix to the enum values to uniquify them. For example:
enum DataMode {
DM_OPTIONAL = 0,
DM_REQUIRED = 1,
DM_REPEATED = 2
}
This is slightly ugly but is ultimately safe. Unfortunately, this change will trigger a lot of little changes throughout the codebase.
Attachments
Issue Links
- relates to
-
DRILL-371 Build Drill C++ client driver
- Resolved