[DRILL-340] Ensure methods intended to create new copies of plan nodes are actually creating copies of all nested objects

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: Future
• Component/s: Query Planning & Optimization
• Assignee: Unassigned
• Reporter: Jason Altekruse
• Created: 27/Dec/13 20:49
• Updated: 20/Apr/15 23:52
• Resolved: 04/Jan/15 21:29

Description

Methods such as getNewWithChildren declared in the PhysicalOperator interface are designed to create copies of plan nodes. These copy operations should not reference any part of the old nodes, thus child objects should be deep copied, including lists of objects. For more information on the desired functionality see here: http://en.wikipedia.org/wiki/Clone_(Java_method)

Existing implementations should be checked for correctness. We may want to create this functionality for logical operators as well, but I do not believe that we should need to do manipulations on logical plans that would require it. Our optimization of plans will happen in the logical to physical plan transformation.