Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-2774

Updated drill-patch-review.py to use git-format-patch

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Reviewable
    • Minor
    • Resolution: Unresolved
    • None
    • Future
    • Tools, Build & Test
    • None

    Description

      The tool currently uses git diff to generate the patches, which does not preserve commit information, and which is required for submitting patches in the Drill community.

      This doesn't work properly when there are multiple commits, so as part of this change, we enforce the requirement that the branch used to create the patch is exactly one commit ahead and zero behind the remote branch.

      Attachments

        1. DRILL-2774.patch
          3 kB
          Steven Phillips
        2. DRILL-2774.patch
          3 kB
          Steven Phillips

        Activity

          People

            sphillips Steven Phillips
            sphillips Steven Phillips
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: