[DRILL-2395] Improve interpreted expression evaluation to only call the setup method once per batch

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: Future
• Component/s: Functions - Drill
• Assignee: Unassigned
• Reporter: Jason Altekruse
• Created: 06/Mar/15 01:40
• Updated: 01/Oct/15 16:37

Description

This enhancement request came out of the review for a patch for DRILL-2060. Copied below is the discussion from there:

Jinfeng:
Do you have a plan to move setup() call into places such that setup() will be called once for each VectorAccessible input?

In the code compile + evaluation model, doSetup() will be called per batch, in stead of per row.

Jason:
I have started working on a fix for this. Its a little complicated with setting constant inputs before the setup method is called. I'm trying to figure out the best way to share code with the rest of the input passing used in the EvalVisitor. Would you be okay with this being opened as an enhancement request to be merged a little later? Considering the current use of the interpreter this won't have an impact on any actual queries today.