[DRILL-1877] Throw unsupported error message for || operator early in the parsing stage

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.9.0
• Component/s: SQL Parser
• Assignee: Sean Hsuan-Yi Chu
• Reporter: Victoria Markman
• Created: 16/Dec/14 22:47
• Updated: 24/Apr/15 21:13
• Resolved: 24/Apr/15 21:13

Description

If we don't plan to support concat operator (||), we should throw a decent error message early.

The error is cryptic:

0: jdbc:drill:schema=dfs> select cast(l_orderkey as varchar(10)) || '-' || cast(l_partkey as varchar(10)) from cp.`tpch/lineitem.parquet`;
Query failed: Query stopped., Line 65, Column 29: "value" is neither a method, a field, nor a member class of "org.apache.drill.exec.expr.holders.VarCharHolder" [ bc85685d-e08a-494b-aa9f-5b3fa4ee4033 on atsqa4-133.qa.lab:3
1010 ]
Error: exception while executing query: Failure while executing query. (state=,code=0)

I believe that error that I'm getting from the query below is the result of not throwing "Unsupported" message earlier.
Please correct me if I'm wrong.

0: jdbc:drill:schema=dfs> select
. . . . . . . . . . . . > cast(l_orderkey as varchar(10)) || '-' || cast(l_partkey as varchar(10))
. . . . . . . . . . . . > from
. . . . . . . . . . . . > (
. . . . . . . . . . . . > select sum(l_quantity),
. . . . . . . . . . . . > l_orderkey,
. . . . . . . . . . . . > l_partkey
. . . . . . . . . . . . > from cp.`tpch/lineitem.parquet`
. . . . . . . . . . . . > group by
. . . . . . . . . . . . > l_orderkey,
. . . . . . . . . . . . > l_partkey
. . . . . . . . . . . . > )
. . . . . . . . . . . . > group by
. . . . . . . . . . . . > cast(l_orderkey as varchar(10)) || '-' || cast(l_partkey as varchar(10));
Query failed: Query failed: Failure while running fragment., You tried to do a batch data read operation when you were in a state of STOP. You can only do this type of operation when you are in a state of OK or OK_NEW_SCHEMA. [ f5cb68a8-7c05-4e02-a104-56081e6d34ce on atsqa4-133.qa.lab:31010 ]
[ f5cb68a8-7c05-4e02-a104-56081e6d34ce on atsqa4-133.qa.lab:31010 ]

Issue Links

• depends upon: DRILL-2054 Support `||` as "concat operator" for varchar inputs
• is duplicated by: DRILL-2054 Support `||` as "concat operator" for varchar inputs
• is duplicated by: DRILL-2354 Documentation for Concat Function & Concat Operator