[DISCOVERY-17] Enumeration returned by Service.providers has a broken behavior

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.5
• Fix Version/s: 0.5
• Assignee: Simone Tripodi
• Reporter: Simone Tripodi
• Due: 08/Apr/11
• Created: 08/Apr/11 16:15
• Updated: 01/Jun/11 20:41
• Resolved: 09/Apr/11 23:17

Description

I find the current Enumeration behavior broken, but please tell me if I'm wrong!!!
This is the actual current behavior:

return new Enumeration<S>() {
            private S object = getNextClassInstance();

            public boolean hasMoreElements() {
                return object != null;
            }

            public S nextElement() {
                if (object == null) {
                    throw new NoSuchElementException();
                }

                S obj = object;
                object = getNextClassInstance();
                return obj;
            }

            private S getNextClassInstance() {
                while (services.hasNext()) {
                    ResourceClass<S> info = services.nextResourceClass();
                    try {
                        return spi.newInstance(info.loadClass());
                    } catch (Exception e) {
                        // ignore
                    } catch (UnsatisfiedLinkError ule) {
                        // ignore
                    } catch (ExceptionInInitializerError eiie) {
                        // ignore
                    }
                }
                return null;
            }
        };

but it should be

return new Enumeration<S>() {

            public boolean hasMoreElements() {
                return services.hasNext();
            }

            public S nextElement() {
                ResourceClass<S> info = services.nextResourceClass();
                try {
                    return spi.newInstance(info.loadClass());
                } catch (Exception e) {
                    // ignore
                } catch (UnsatisfiedLinkError ule) {
                    // ignore
                } catch (ExceptionInInitializerError eiie) {
                    // ignore
                }
                return null;
            }
        };

I think there's no need to comment both codes, please tell me why the first one should be right