Issue Details (XML | Word | Printable)

Key: DIRTSEC-2
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Alex Karasulu
Reporter: David Jencks
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Triplesec

Bring build into the modern world

Created: 21/Dec/06 01:01 AM   Updated: 06/May/09 04:33 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works DIR-198.patch 2006-12-21 01:02 AM David Jencks 64 kB
Text File Licensed for inclusion in ASF works DIRTSEC-2-2.patch 2006-12-22 06:28 PM David Jencks 37 kB

Resolution Date: 08/Jan/07 05:47 AM


 Description  « Hide
I updated the triplesec build to:

- uses groupId org.apache.directory.triplesec
- include all dependency versions in root pom dependencyManagement
- include all plugin versions in root pom pluginManagement
- use latest apacheDS and wicket and a few other projects
- actually build

The attached patch has minimal format changes. It really needs pom cleanup, but I am reluctant to supply a patch that changes almost every line of every file involved.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
David Jencks made changes - 21/Dec/06 01:02 AM
Field Original Value New Value
Attachment DIR-198.patch [ 12347620 ]
Alex Karasulu made changes - 21/Dec/06 05:18 PM
Key DIR-198 DIRTSEC-2
Project Directory [ 10400 ] Triplesec [ 12310592 ]
Alex Karasulu made changes - 21/Dec/06 05:18 PM
Summary TRIPLESEC bring build into the modern world Bring build into the modern world
Alex Karasulu added a comment - 21/Dec/06 05:28 PM
That's funny David this is exactly what I did myself on Dec 19th. I put a bunch of deps into dependencyManagement and updated most of the dependencies to the latest versions. I got the build working too.

I don't know what this will do now wrt to your patch so I'll just try to apply it and see what happens.

BTW the one thing that I did not do yet was change the groupId. Let me attempt to apply your patch then give more feed back. Thanks!

Alex Karasulu added a comment - 21/Dec/06 05:32 PM
Ok this patch has some crazy rejects in it. Sorry for asking this but could you svn up and check that you don't have any conflicts? Thanks!

David Jencks added a comment - 22/Dec/06 06:28 PM
Attached patch resolves conflicts with Alex's attempt to do the same thing and also:

- moves all the rest of the dependency versions for external jars to dependencyManagement
- adds a pluginManagement section to specify the versions of all plugins used
- updates some dependency versions (jetty, tomcat at least)
- removes some unused dependencies from dependencyManagement
- uses the geronimo servlet 2.4 and jsp 2.0 spec jars everywhere instead of a mix of servlet 2.3 and 2.4 jars and not-sure-what jsp jars. I prefer to know what spec version I am using from the artifact name.

David Jencks made changes - 22/Dec/06 06:28 PM
Attachment DIRTSEC-2-2.patch [ 12347768 ]
Repository Revision Date User Message
ASF #490644 Thu Dec 28 04:15:40 UTC 2006 djencks DIRTSEC-2 Further specificity for dependencyManagement and pluginManagement. There might still be mismatch between apacheds components
Files Changed
MODIFY /directory/trunks/triplesec/configuration-io/pom.xml
MODIFY /directory/trunks/triplesec/guardian-api/pom.xml
MODIFY /directory/trunks/triplesec/configuration/pom.xml
MODIFY /directory/trunks/triplesec/webapp-registration/pom.xml
MODIFY /directory/trunks/triplesec/utils-hauskeys/pom.xml
MODIFY /directory/trunks/triplesec/jaas/pom.xml
MODIFY /directory/trunks/triplesec/swing-admin/pom.xml
MODIFY /directory/trunks/triplesec/installers/pom.xml
MODIFY /directory/trunks/triplesec/webapp-config/pom.xml
MODIFY /directory/trunks/triplesec/wicket-tools/pom.xml
MODIFY /directory/trunks/triplesec/main/pom.xml
MODIFY /directory/trunks/triplesec/pom.xml
MODIFY /directory/trunks/triplesec/guardian-ldif/pom.xml
MODIFY /directory/trunks/triplesec/testdata/pom.xml
MODIFY /directory/trunks/triplesec/integration/pom.xml
MODIFY /directory/trunks/triplesec/changelog/pom.xml
MODIFY /directory/trunks/triplesec/webapp-activation/pom.xml
MODIFY /directory/trunks/triplesec/crypto/pom.xml
MODIFY /directory/trunks/triplesec/sms/pom.xml
MODIFY /directory/trunks/triplesec/tools/pom.xml
MODIFY /directory/trunks/triplesec/admin-api/pom.xml
MODIFY /directory/trunks/triplesec/store/pom.xml
MODIFY /directory/trunks/triplesec/webapp-root/pom.xml
MODIFY /directory/trunks/triplesec/webapp-demo/pom.xml
MODIFY /directory/trunks/triplesec/guardian-ldap/pom.xml
MODIFY /directory/trunks/triplesec/swing-demo/pom.xml
MODIFY /directory/trunks/triplesec/profile/pom.xml
MODIFY /directory/trunks/triplesec/webapp-changelog/pom.xml
MODIFY /directory/trunks/triplesec/webapp-servlet-demo/pom.xml
MODIFY /directory/trunks/triplesec/webapp-wicket-admin/pom.xml
MODIFY /directory/trunks/triplesec/otp/pom.xml
MODIFY /directory/trunks/triplesec/verifier/pom.xml
MODIFY /directory/trunks/triplesec/webapp-wicket-admin/src/main/java/org/safehaus/triplesec/adminui/security/PageAuthorizationStrategy.java
MODIFY /directory/trunks/triplesec/webapp-wicket-admin/src/main/java/org/safehaus/triplesec/adminui/view/TriplesecAdminApplication.java

David Jencks added a comment - 28/Dec/06 04:19 AM
Applied in rev 490644.

There might still be some kind of version mismatch between apacheds components: while the build works fine most of the time I once got an IncompatibleClassChangeError in a webapp-admin test.

I don't seem to have jira privileges to close this yet.

David Jencks added a comment - 08/Jan/07 05:47 AM
Should I be able to close this? I applied my patch.

David Jencks made changes - 08/Jan/07 05:47 AM
Fix Version/s 1.0.0 [ 12312233 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Emmanuel Lecharny made changes - 06/May/09 04:33 PM
Status Resolved [ 5 ] Closed [ 6 ]