Modify the semantic of LdapDN.toString() method

• Key: DIRSERVER-808
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Emmanuel Lecharny
• Reporter: Emmanuel Lecharny
• Component/s: ldap
• Fix Version/s: 1.5.1

Description

The semantic of LdapDN.toString() method is really bad : it returns a normalized form of the DN. By no means this should have been the case, so I suggest to switch it back to what it should have been from the beginning :

toString() returns the user provided DN
getUpName() return the user provided DN ( for completness)
getNormName() returns the normalized form of the DN

Of course, many test cases will be impacted, but this is not something that can't be fixed in less that a few hours.

Comments

I have started to modify the semantic of this class, but much should be done. May be a complete review of the API and the internal of LdapDN should be done. Alex suggested that may be it could be a good idea to have two classes : LdapDN and NormalizedLdapDN, to express the different natures of a DN. It could also be good to reviex the code, which is very complicated...

[Emmanuel Lecharny]

the toString() method has to be mapped to getUpName() for debug purposes.

getUpName() and getNormName() methods have been created

[Emmanuel Lecharny]

The semantic has been changed

[Emmanuel Lecharny]

done