update commons-lang from 2.0 to 2.1

• Key: DIRSERVER-750
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Bastiaan Bakker
• Affects Version/s: 1.0-RC4

Description

ApacheDS currently uses jakarta commons-lang 2.0, which is over three years old and incompatible with JDK1.5 (enum keyword conflict). comons-lang-2.1 (the latest released version) is backwards compatible with 2.0 (with one exception that doesn't affect ApacheDS) and contains several bugfixes and improvements. It's also required by spring-ldap, a package that can be useful in partition backend code.

Comments

[Bastiaan Bakker]

hmm, I see I created this issue with priority 'major', should be 'minor' I guess. Looks like I can't modify the priority however....

Anyway, apacheds-shared-ldap, has a build dep on commons-lang in its pom, but doesn't actually use commons-lang. So the whole dep can be removed.
For apacheds server, it recompiles fine with commons-lang 2.1.
I do see usage of comons-lang in server-jndi/src/main/java/org/apache/directory/server/jndi/ServerContextFactory.java and
core/src/test/java/org/apache/directory/server/core/jndi/LdapJndiPropertiesTest.java without a commons-lang dep in the correspondind poms. Do they rely on a transitive dep?

[Stefan Zoerner]

Priority changed to "minor", as suggested by Bastiaan in his mail.

I confirm that commons-lang is not used in shared-ldap. It can be removed.

We can also bump up to 2.1, it's not a big deal.

Pom.xml are inherited, so you may have a dependecy declared on a upper level. In this case, it's something different. Apacheds depend on shared, which depends on commons-lang, this is why you have this dependencies. Yes, it's transitive.

It would be cool to switch to 2.1 before the 1.0 code freeze ...

wdyt ?

[Emmanuel Lecharny]

1.0.1 already use only commons-lang 2.1
There were some remaining 2.0 version in ADS 1.5.0 :
http://svn.apache.org/viewvc?view=rev&rev=521396
and
http://svn.apache.org/viewvc?view=rev&rev=521397