Possible double add of extensibleMatchFilter in filter tree

• Key: DIRSERVER-723
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Emmanuel Lecharny
• Reporter: Pierre-Arnaud Marcelot
• Component/s: ldap

Description

In internal class "GrammarAction("Init extensible match Filter" )" (line 97), I think that the extensibleMatchFilter may be added twice in the Filter tree.

The following code add the Filter :
------------------
// Get the parent, if any
                    Filter currentFilter = searchRequest.getCurrentFilter();

                    if ( currentFilter != null )
                    {
                        // Ok, we have a parent. The new Filter will be added to
                        // this parent, then.
                        ( ( ConnectorFilter ) currentFilter ).addFilter( extensibleMatchFilter );
                        extensibleMatchFilter.setParent( currentFilter );
                    }
                    else
                    {
                        // No parent. This Filter will become the root.
                        searchRequest.setFilter( extensibleMatchFilter );
                        extensibleMatchFilter.setParent( searchRequest );
                    }
------------------

and then, the addCurrentFilter( extensibleMatchFilter ) method is called and does the same thing another time.

Comments

[Emmanuel Lecharny]

Whaoo !!! What a bug !

Thanks a lot for the find, I could have spend hours trying to find it later !

Fixed, the code has been removed.

[Pierre-Arnaud Marcelot]

Great!

I'm closing the issue.