Tools improvement and add of Export Command and JUnit tests

• Key: DIRSERVER-679
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Pierre-Arnaud Marcelot
• Component/s: tools
• Affects Version/s: 1.0-RC3

Description

Working on a new plugin supporting LDIF Import/Export for LDAP Studio ( http://docs.safehaus.org/display/LDAPSTUDIO ), I wanted to use the Apache DS to import an LDIF file.
But the Import Command can only be accessed via a Command Line and don't give enough feedback for a front-end GUI (particularly to show the progress of the operation).

Emmanuel (Lécharny) also pointed out the fact that it may be interesting for future developments to be able to access the Tools in a "kind of" Client/Server way. The tools running on a the server's station, and the command launched from another machine.

So, he asked me to modify the tools to add this Client/Server feature and make them callable more easily from other application and give better feedback.

I made a small documentation on this on Safehaus : http://docs.safehaus.org/display/LDAPSTUDIO/Apache+DS+Tools+rewrite . It is also attached to this post as a PDF, since LDAPStudio's Confluence isn't accessible to everyone.

In the patch you'll find the tools with the new architecture (defined with Emmanuel).
I also added a new command that export entries as LDIF file, and some JUnit tests for the Import, Export and GracefulShutdown command.

Feel free to give me your feedback about this.

Comments

[Pierre-Arnaud Marcelot]

Here's the patch

[Pierre-Arnaud Marcelot]

Here's the documentation

[Ersin Er]

This patch, although a nice contribution, may need some reviewing. Here are a few points:

* The paths it updates are not relative to our repository but local file system.
* There are some lines prefixed with - (minus) which means they are to be excluded, but they do not even exist in the current code base.
* Although it is targeted at 1.0-RC3, it has some Stored Procedure related stuff.

Well, I may not be %100 correct about my concerns but a review would be good.

Thanks Pierre!

[Pierre-Arnaud Marcelot]

Here's a new patch, since there was a bug in previous generated by Subclipse in Eclipse.

[Ersin Er]

BTW, in my experience some best practives for creating and testing patches are as follows:

* Create a patch from command line or IDE, but be sure you do it with relative paths.
* svn checkout a complete new code repo.
* Apply the patch to the new downloaded code base.
* Build the patched code and run all unit and integration tests.

HTH.

[Ersin Er]

The new patch seems to be better but it should be clearified if it's for 1.1 or 1.0. As 1.0 does not have any Stored Procedure mechanism, this patch currently can only apply to 1.1.

[Pierre-Arnaud Marcelot]

Thanks Ersin.

I thought that trunks was version 1.0-RC3.

I'm going to post two patches, one for 1.0, another for 1.1.

Patch applied in september

[Pierre-Arnaud Marcelot]

Thanks Emmanuel.