ExceptionService.modify() is not generating the correct exception

• Key: DIRSERVER-664
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Emmanuel Lecharny
• Reporter: Giamma
• Affects Version/s: 1.0-RC4

Description

When trying to modify an attribute with an existing value, the following exception should be generated:
LdapAttributeInUseException( "Trying to add existing value 'XYZ' to attribute ABC");

But instead the code is generating a IndexOutOfBoundsException because there is a bug in the code that is generating the correct exception.

This is the wrong code:

 public void modify( NextInterceptor nextInterceptor, Name name, ModificationItem[] items ) throws NamingException
    {
        // check if entry to modify exists
        String msg = "Attempt to modify non-existant entry: ";
        assertHasEntry( nextInterceptor, msg, name );

        Attributes entry = nexus.lookup( name );
        for ( int ii = 0; ii < items.length; ii++ )
        {
            if ( items[ii].getModificationOp() == DirContext.ADD_ATTRIBUTE )
            {
                Attribute modAttr = items[ii].getAttribute();
                Attribute entryAttr = entry.get( modAttr.getID() );

                if ( entryAttr != null )
                {
                    for ( int jj = 0; jj < modAttr.size(); jj++ )
                    {
                        if ( entryAttr.contains( modAttr.get( jj ) ) )
                        {
                            throw new LdapAttributeInUseException( "Trying to add existing value '"
                                    + modAttr.get( ii ) + "' to attribute " + modAttr.getID() ); <----- HERE IS THE PROBLEM, should use modAttr.get( jj )
                        }
                    }
                }
            }
        }
        nextInterceptor.modify( name, items );
    }

Comments

[Emmanuel Lecharny]

Thanks a lot Giamma !

The fix was perfect !

I added a junit test case just in case, and fixed the code the way you proposed to do.

[Gianmaria Clerici]

   [[ Old comment, sent by email on Thu, 27 Jul 2006 19:43:29 -0700 ]]

You are welcome.

But I can do better then that :-)

CIAO


Gianmaria Clerici aka Giamma
Email <mailto:[e-mail]>[e-mail]
Mobile [phone] Home [phone]
AOL/YAHOO IM giamma13 SMS [e-mail]
    * <http://dj.giamma.com/&gt;dj.giamma.com
    * www.triplepower.org
    * <http://people.tribe.net/giamma/blog&gt;people.tribe.net/giamma/blog
    * www.flickr.com/photos/giamma
    * www.youtube.com/user/giamma

[Emmanuel Lecharny]

closed