ClassCast exception when fetching DNs from root DES

• Key: DIRSERVER-658
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Emmanuel Lecharny
• Reporter: Emmanuel Lecharny
• Affects Version/s: 1.0-RC4

Description

When fetching for DNs in LdapBrowser, you get an exception while encoding the SearchResultEntry :

...
Caused by: java.lang.ClassCastException: org.apache.directory.shared.ldap.name.LdapDN
at org.apache.directory.shared.ldap.codec.search.SearchResultEntry.computeLength(SearchResultEntry.java:240)
at org.apache.directory.shared.ldap.codec.LdapMessage.computeLength(LdapMessage.java:530)
at org.apache.directory.shared.ldap.codec.LdapMessage.encode(LdapMessage.java:602)
at org.apache.directory.shared.ldap.codec.TwixEncoder.encodeBlocking(TwixEncoder.java:121)
at org.apache.directory.shared.ldap.codec.TwixEncoder.encode(TwixEncoder.java:200)
at org.apache.directory.shared.ldap.message.MessageEncoder.encode(MessageEncoder.java:131)
at org.apache.mina.filter.codec.asn1.Asn1CodecEncoder.encode(Asn1CodecEncoder.java:55)
at org.apache.mina.filter.codec.ProtocolCodecFilter.filterWrite(ProtocolCodecFilter.java:226)
... 22 more

The problem is that when encoding a SearchResultEntry, the values are supposed to be Strings or byte arrays, not LdapDNs. When you fetch for DNs in the root DSE, the result is stored in the SearchResultEntry as LdapDN objects, not Strings, and it's allowad, as the method which set the value accept an Object.

We have to fix two problems :
- first, check that the Object is either a String or a byte[], nothing else (defensive programming)
- second, avoid storing LdapDN objects where String or byte[] are expected :)

Comments

[Emmanuel Lecharny]

A little mistake : we are trying to encode Attributes object, which contains Naming contexts, which themselves contain LdapDN.

[Emmanuel Lecharny]

I think that a patch like this one could solve the problem :

Index: apacheds/core/src/main/java/org/apache/directory/server/core/partition/DefaultDirectoryPartitionNexus.java
===================================================================
--- apacheds/core/src/main/java/org/apache/directory/server/core/partition/DefaultDirectoryPartitionNexus.java (revision 416873)
+++ apacheds/core/src/main/java/org/apache/directory/server/core/partition/DefaultDirectoryPartitionNexus.java (working copy)
@@ -428,7 +428,7 @@
         partitions.put( partition.getSuffix().toString(), partition );
 
         Attribute namingContexts = rootDSE.get( NAMINGCTXS_ATTR );
- namingContexts.add( partition.getUpSuffix() );
+ namingContexts.add( partition.getUpSuffix().toString() );
     }
 
 
@@ -442,7 +442,7 @@
         }
 
         Attribute namingContexts = rootDSE.get( NAMINGCTXS_ATTR );
- namingContexts.remove( partition.getUpSuffix() );
+ namingContexts.remove( partition.getUpSuffix().toString() );
         partitions.remove( key );
 
         partition.sync();


Alex, is this ok with you ?

[Emmanuel Lecharny]

Fixed by modifiying the way NamingContexts are stored in the Attribute object : they are now stored as String, not as LdapDN objects.

Regression tests passed ok.

[Emmanuel Lecharny]

Fixed