Avoid multiple creation of LdapDN

• Key: DIRSERVER-652
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Emmanuel Lecharny
• Affects Version/s: 1.0-RC3
• Fix Version/s: 1.0-RC4

Description

After having profiled the server, I found that the LdapDN<init>(Name) has been called 3000 times, because the LdapPrincipal contains a Name instead of a LdapDN element.

We should check that the passed Name is not an instance of LdapDN before calling new LdapDN( Name) in
org.apache.directory.server.core.authz.DefaultAuthorizationService.protectLookUp() method
 :
...
LdapDN principalDn = new LdapDN( ( ( ServerContext ) ctx ).getPrincipal().getJndiName() );
...

could be :
Name name = ( ( ServerContext ) ctx ).getPrincipal().getJndiName() ;

LdapDN principalDn= ( name instanceof LdapDN ? name.clone() : new LdapDN( name ) );
    

Comments

[Emmanuel Lecharny]

I evaluate the gain in performance for search operations to 3,7%. (tests done with a server containing 10000 entries and doing a random search)

[Emmanuel Lecharny]

We have removed all unecessary DN parsing, so we can close this issue

Work has been done two months ago.