transport explanations in NamingExceptions why searches fail back to the client

• Key: DIRSERVER-649
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Ralf Hauser
• Component/s: ldap
• Fix Version/s: 1.5.5

Description

Our ldap application has a custom partition and we only allow restricted searches on it.

If the queries do not comply with our rules, we throw a NamingException.
I guess good candidates for this are
- CannotProceedException
- NoPermissionException
The good news is that I even can provide the exception constructor with some extra information
that might help the searching user to adapt the query in order to succeed subsequently.

Unfortunately, such exception explanation are ignored in SearchHandler.java and only
  "failed on search operation"
is returned to the client

Please find a diff below how this might be solved.

Secondly, it would be great to be able to localize also the main error texts. Since our
searches are only executed after a "bind" we do have the possibility to know the locale
preferences from our own user-data-base.

What do you think.



--- SearchHandler.java.orig 2006-06-16 09:56:02.000000000 +0200
+++ SearchHandler.java 2006-06-16 09:57:28.000000000 +0200
@@ -345,7 +345,13 @@
 
             LdapResult result = req.getResultResponse().getLdapResult();
             result.setResultCode( code );
- result.setErrorMessage( msg );
+ String extraInfo="";
+ if (e.getMessage() != null) {
+ if (e.getMessage().trim().length()>0) {
+ extraInfo=": " + e.getMessage();
+ }
+ }
+ result.setErrorMessage( msg + extraInfo );
 
             if ( ( e.getResolvedName() != null )
                 && ( ( code == ResultCodeEnum.NOSUCHOBJECT ) || ( code == ResultCodeEnum.ALIASPROBLEM )

Comments

[Alex Karasulu]

Sure I will apply this for you. However could you attach an svn diff generated patch to this issue: unfortunatly things get mutilated by JIRA text formating. Thanks!

[Ralf Hauser]

see also DIRSERVER-649

[Ralf Hauser]

oops, should have been the reference to DIRSERVER-640 where the same issue exists with bind exceptions

This issue and http://issues.apache.org/jira/browse/DIRSERVER-640 appear to me to be special cases of an issue I raised against LDAP earlier: http://issues.apache.org/jira/browse/DIRSERVER-619.

I second Ralf's suggestion about localisation of server messages eventually. I currently use a message class that stores message format + args, and can be rendered to/from XML as well resolved to a localised string either at the server or the client as required (client being the most useful option where geographically diverse clients access a centrail server).

[Emmanuel Lecharny]

I think we need this feature.

[Alex Karasulu]

Postponed.

[Emmanuel Lecharny]

This long witing issue has been fixed. We now transmit the initial cause to the client, and if the server is in debug mode, we also transmit the stack trace.