Performing two modifications on a single attribute within a single modify operation fails.

• Key: DIRSERVER-636
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Emmanuel Lecharny
• Reporter: Stefan Zoerner
• Affects Version/s: 1.0-RC3

Environment

ApacheDS 1.0 RC 3
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_04-b05)
Microsoft Windows XP version 5.1 Service Pack 1

Description

Performing two modifications on a single attribute within a single modify operation fails.

After creating an entry like this:

dn: cn=Kate Bush,dc=example,dc=com
objectclass: person
objectclass: top
sn: Bush
cn: Kate Bush

e.g.

$ ldapmodify -h localhost -p 10389 -D "uid=admin,ou=system" -w ****** -a -f KateBush.ldif
adding new entry cn=Bush\, Kate,dc=example,dc=com

I perform a modify operation with two modification items:

dn: cn=Kate Bush,dc=example,dc=com
changetype: modify
add: description
description: Kate Bush is a British singer-songwriter.
description: She has become one of the most influential female artists of the twentieth century.
-
delete: description
description: She has become one of the most influential female artists of the twentieth century.

which results in an error:

$ ldapmodify -h localhost -p 10389 -D "uid=admin,ou=system" -w ****** -f twoModifications.ldif
modifying entry cn=Kate Bush,dc=example,dc=com
ldap_modify: No such attribute
ldap_modify: additional info: failed to modify entry cn=Kate Bush,dc=example,dc=com

The expected result is to perform both modification items within a single transaction, resulting in an entry like this:

dn: cn=Kate Bush,dc=example,dc=com
objectclass: person
objectclass: top
sn: Bush
cn: Kate Bush
description: Kate Bush is a British singer-songwriter.

Find an equivalent JNDI JUnit test case attached.

Comments

[Stefan Zoerner]

A JUnit test case which performs the operations described in the issue with JNDI, and fails on ApacheDS.

[Emmanuel Lecharny]

This is an error deep into the server.

Modification operations should be considered as atomic operations, this a add of an attribute followed by a remove should act as if the entry contains the added attribute when we try to remove it. This is not the case atm, because we compare the modifications with the actual entry, woithout applying the modifications on the fly.

A fix in the SchemaService modify's method is being tested.

[Emmanuel Lecharny]

Ok, the bug has been fixed. We now apply the modification to a cloned entry, and check that there are no incompatible modifications.

[Stefan Zoerner]

I have retetested the problem on the current optimization branch (Revision 427216) and I can confirm that it is fixed. Thanks Emmanuel! I'll close the issue if the code is merged in the 1.0 branch.

[Stefan Zoerner]

I have retested this with the current 1.0 version of ApacheDS. Works fine, thus I close this issue. Thanks Emmanuel!