NamingException messages are thrown away by MessageHandlers

• Key: DIRSERVER-619
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Alex Karasulu
• Reporter: Norval Hope
• Component/s: ldap
• Affects Version/s: 1.0-RC3
• Fix Version/s: 1.5.0, 1.0-RC4

Description

The LDAP MessageHandlers (e.g. org.apache.directory.server.ldap.support.AddHandler) throw away the messages attached to caught NamingExceptions before rethrowing their own newly created exceptions:


        catch ( NamingException e )
        {
            String msg = "failed to add entry " + req.getEntry();

            if ( log.isDebugEnabled() )
            {
                msg += ":\n" + ExceptionUtils.getStackTrace( e );
            }

where I would like to see

        catch ( NamingException e )
        {
            String msg = "failed to add entry " + req.getEntry() + ": " + e.getMessage();

instead. Without this fix all meaningful details about the problem are thrown away and can not be displayed in the LDAP client meaning that server log files have to be inspected immediately.

In addition, this seems like a simple oversight as even in the debugging case only the server stacktrace is merged into the exception message and hence sent to the client where the original NamingException message is much more valuable for debugging then the stacktrace alone.

Comments

[Norval Hope]

Patch is from top-level of "trunks"

[Norval Hope]

On further investigation e.getMessage() would be better replaced by e.toString() which includes information about the root cause, if one has been set.

[Alex Karasulu]

Committed changes to 1.0 branch on revision 437287.
Committed changes to 1.1 branch on revision 437288.