ControlType are not stored as strings

• Key: DIRSERVER-50
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Emmanuel Lecharny
• Reporter: Emmanuel Lecharny
• Component/s: asn1
• Affects Version/s: pre-1.0
• Fix Version/s: pre-1.0

Description

Reported by Van Nhu today :

> Hi all,
>
> According to the RFC 2251, the "controlType" attribute
> of an LDAP Control "...MUST be a UTF-8 encoded
> dotted-decimal representation of an OBJECT IDENTIFIER
> which uniquely identifies the control". Essentially,
> this means that the "controlType" attribute is an
> OCTET STRING and should be treated as such.
>
> However, the Twix ASN1 codec is treating this
> attribute as an OBJECT IDENTIFIER. This results in
> incorrect decoding/decoding of LDAP Controls.
>
> I suggest that we change the type of the "controlType"
> attribute of the org.apache.asn1new.ldap.pojo.Control
> class from OID to LdapString to fix the problem. A
> patch, which includes a test for exposing the problem
> and validating the fix, is attached for your
> reference.
>
> With Regards,
> Van

Comments

[Emmanuel Lecharny]

This was a side effect on my work on SPNEGO OID's.

The problem has been fixed changing the internal type of LdapControl form OID to LdapString.

The test has been added.

Another test has been fixed accordingly.

Thanks van !

[Emmanuel Lecharny]

closing issues