Issue Details (XML | Word | Printable)

Key: DIRSERVER-488
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Trustin Lee
Reporter: Trustin Lee
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Directory ApacheDS

Make CoreContextFactory more extensible

Created: 12/Jun/05 11:08 AM   Updated: 10/Feb/06 12:43 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

Resolution Date: 13/Jun/05 12:25 PM


 Description  « Hide
For now, we override existing methods to extend CoreContextFactory, but it is not actually safe way to extend it. We could use template method pattern so that users implement only template methods to extend CoreContextFactory.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #190336 Mon Jun 13 03:11:14 UTC 2005 trustin Resolved: DIREVE-160 Make CoreContextFactory more extensible
Files Changed
MODIFY /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/AbstractCoreTest.java
ADD /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/jndi/RootNexusProxy.java
ADD /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/jndi/ContextFactoryContext.java
ADD /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/jndi/AbstractContextFactory.java
DEL /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/BackendSubsystem.java
MODIFY /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/jndi/CoreContextFactory.java
MODIFY /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/jndi/JndiProvider.java
MODIFY /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/invocation/Invocation.java
MODIFY /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/RootNexus.java
MODIFY /directory/apacheds/branches/direve-158/core/src/main/java/org/apache/ldap/server/interceptor/InterceptorChain.java

Trustin Lee added a comment - 13/Jun/05 12:25 PM
I added AbstractContextFactory that provides hook methods:

* beforeStartup( ContextFactoryContext )
* afterStartup( ContextFactoryContext )
* beforeShutdown( ContextFactoryContext )
* afterShutdown( ContextFactoryContext )
* beforeSync( ContextFactoryContext )
* afterSync( ContextFactoryContext )

CoreContextFactory now extends AbstractContextFactory with empty hook methods. You can extend AbstractContextFactory and implement these hook methods.

Trustin Lee made changes - 13/Jun/05 12:25 PM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Alex Karasulu made changes - 10/Feb/06 12:43 PM
Key DIREVE-160 DIRSERVER-488
Project Directory Server [ 10516 ] Directory ApacheDS [ 12310260 ]
Affects Version/s 0.9 [ 11003 ]
Affects Version/s 0.8 [ 10990 ]
Fix Version/s 0.9.1 [ 11125 ]
Component/s jndi-provider [ 11088 ]