[#DIRSERVER-392] Modify operation (removal) provides wrong return codes in two situations.

Directory ApacheDS

Modify operation (removal) provides wrong return codes in two situations.

Created: 27/Aug/05 12:02 AM Updated: 10/Feb/06 12:34 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	ModifyRemoveTest.java	2005-08-27 01:07 AM	Stefan Zoerner	9 kB

Issue Links:

Reference

This issue is related to:

~~DIRSERVER-480~~ Move schema checking code in LDAP protocol provider into the schema interceptor

Resolution Date:

29/Aug/05 02:08 PM

Description

« Hide

The modify operation provides wrong return codes in two cases:

1. Removal of an attribute which does not occur in the entry (expected result is error code 16: noSuchAttribute)
2. Removal of an invalid attribute, i.e. not existing within the schema (expected result is error code 17: undefinedAttributeType)

This is quite similar to DIREVE-226.

I attach a subclass of AbstractServerTest which contains several test methods for basic removal ops. Due to the recent changes regarding schema checks, most of them succeed. Two tests check for the return codes above (and fail). It includes also a test which deletes a required attribute (not part of RDN), which fails -- but this is expected due to the current development progress.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Stefan Zoerner added a comment - 27/Aug/05 01:07 AM

Here is the test case for the return value check. Relevant test methods within the class:

testRemoveAttributeNotPresent
testRemoveAttributeNotValid

Stefan Zoerner made changes - 27/Aug/05 01:07 AM

Field	Original Value	New Value
Attachment		ModifyRemoveTest.java [ 12312014 ]

Repository	Revision	Date	User	Message
ASF	#264063	Mon Aug 29 05:07:15 UTC 2005	akarasulu	Added some schema checks to prevent improper modify operations from succeeding. Namely we added checks to satisfy the modify tests submitted by Stefan in the following JIRA DIREVE-232 issue: http://issues.apache.org/jira/browse/DIREVE-232 His test case was added as well as the changes to make sure the tests pass. NOTE: most of these fixes testing for schema correctness should be moved into the schema checking interceptor however there may be some information loss without access to the request - this should be inspected before moving this code into the interceptor.
				Files Changed
				MODIFY /directory/protocol-providers/ldap/trunk/src/main/java/org/apache/ldap/server/protocol/ModifyHandler.java MODIFY /directory/protocol-providers/ldap/trunk/src/main/java/org/apache/ldap/server/protocol/CompareHandler.java ADD /directory/apacheds/trunk/main/src/test/org/apache/ldap/server/ModifyRemoveTest.java

Alex Karasulu made changes - 29/Aug/05 12:56 PM

Status

Open [ 1 ]

In Progress [ 3 ]

[ Permlink | « Hide ]

Alex Karasulu added a comment - 29/Aug/05 12:56 PM

Let's fix this now before the release.

Alex Karasulu made changes - 29/Aug/05 12:56 PM

Fix Version/s

0.9.2 [ 12310192 ]

[ Permlink | « Hide ]

Alex Karasulu added a comment - 29/Aug/05 02:08 PM

Committed test case and fixes in revision 264063 here:

http://svn.apache.org/viewcvs.cgi?view=rev&rev=264063

Alex Karasulu made changes - 29/Aug/05 02:08 PM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

Alex Karasulu made changes - 29/Aug/05 02:12 PM

Link

This issue is related to DIREVE-233 [ DIREVE-233 ]

[ Permlink | « Hide ]

Stefan Zoerner added a comment - 03/Sep/05 04:52 PM

I have retested the functionality in the current version. The server exhibits the expected behavior to the client, therefor I close this issue now. Thank you Alex for painting two of my test cases green!

Stefan Zoerner made changes - 03/Sep/05 04:52 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Alex Karasulu made changes - 10/Feb/06 12:34 PM

Affects Version/s	0.9.2 [ 12310192 ]
Project	Directory Server [ 10516 ]	Directory ApacheDS [ 12310260 ]
Fix Version/s	0.9.2 [ 12310192 ]
Key	DIREVE-232	~~DIRSERVER-392~~