[#DIRSERVER-326] ServerDirContext.search() with filter arguments always gets index out of bounds (in two places).

Directory ApacheDS

ServerDirContext.search() with filter arguments always gets index out of bounds (in two places).

Created: 21/Sep/05 05:00 AM Updated: 21/Apr/07 11:18 AM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	search-filterargs.patch	2005-09-21 05:01 AM	Jacob S. Barrett	4 kB

Resolution Date:

22/Sep/05 11:56 AM

Description

« Hide

When searching the ServerDirContext with filter arguments it throws index out of bounds exceptions in two places.

The first place is where it attempts to substitute the value into the buffer it uses the index of the } char as the index into the arguments.

The second one, after you fix the first, is when the search for { reaches the end of the string.

The attached patch fixes both and includes a JUnit test.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Jacob S. Barrett made changes - 21/Sep/05 05:01 AM

Field	Original Value	New Value
Attachment		search-filterargs.patch [ 12314477 ]

Repository	Revision	Date	User	Message
ASF	#290878	Thu Sep 22 02:55:13 UTC 2005	trustin	Applied a patch by Jacob Barrett for DIREVE-266: ServerDirContext.search() with filter arguments always gets index out of bounds (in two places).
				Files Changed
				MODIFY /directory/apacheds/trunk/core/src/test/org/apache/ldap/server/jndi/SearchContextTest.java MODIFY /directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/jndi/ServerDirContext.java

[ Permlink | « Hide ]

Trustin Lee added a comment - 22/Sep/05 11:56 AM

The patch looks good. I applied it. But wouldn't there be any nested {} blocks? Just a question by my curiousity.

Trustin Lee made changes - 22/Sep/05 11:56 AM

Fix Version/s		0.9.3 [ 12310193 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Jacob S. Barrett added a comment - 22/Sep/05 11:54 PM

I don't think nested {} are supported. The don't appear to be in MessageFormat, which is similar. There is one thing this is missing though. Might the values need to be encoded? Maybe not since this is really for inproc access to the directory. What are your thoughts?

Alex Karasulu made changes - 10/Feb/06 12:34 PM

Affects Version/s	0.9 [ 11003 ]
Affects Version/s	0.8 [ 10990 ]
Affects Version/s	0.9.3 [ 12310193 ]
Fix Version/s	0.9.3 [ 12310193 ]
Project	Directory Server [ 10516 ]	Directory ApacheDS [ 12310260 ]
Key	DIREVE-266	~~DIRSERVER-326~~
Affects Version/s	0.9.1 [ 11125 ]
Component/s	jndi-provider [ 11088 ]
Affects Version/s	0.9.2 [ 12310192 ]

[ Permlink | « Hide ]

Emmanuel Lecharny added a comment - 21/Apr/07 11:18 AM

Closing all issues created in 2005 and before which are marked resolved

Emmanuel Lecharny made changes - 21/Apr/07 11:18 AM

Status

Resolved [ 5 ]

Closed [ 6 ]