NormalizationService is failing to parse escaped names

• Key: DIRSERVER-297
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Alex Karasulu
• Reporter: Giamma

Description

I wrote a custom partition to extract data from our oracle database.
Some of the names returned from out db needs to be escaped because they have special chars like: "," "/" and "="
This is done using LdapName.escapeAttributeValue().

Unfortunately the DnParser (in NormalizationService) is not doing the right thing when processing these escaped names.

I had to change the code in NormalizationService to still call the parser (to check invalid DN syntax) but I skipped
using the text returned by the parser because it would remove spaces after an escaped ","

Let's say I have a RDN like this:
"ou=some test, something else"

After I escaped it it wil be like this:
"ou=some test\\, something else"

The parser will remove the space after the escaped ","
"ou=some test\\,something else"

And that breaks the code in my custom partition because it's not finding the right object.

Here is the fix I made.
But it's just an hack. I think the problem is in the DnParser. But I do not have the source for that.

 protected void process( NextInterceptor nextInterceptor, Delete call ) throws NamingException
    {
        synchronized( parser )
        {
            // call.getName( parser.parse( call.getName().toString() ) );
            // call it anyway to catch invalid DN syntax
            parser.parse( call.getName().toString() );
        }

        super.process( nextInterceptor, call );
    }

Comments

[Alex Karasulu]

Tried to isolate this bug with the following test case committed on revision 239929 here:

http://svn.apache.org/viewcvs.cgi?rev=239929&view=rev

[Alex Karasulu]

The test case commited above passes without a problem. The space in the value is not lost after escaping the ',' before the space. Are you sure this problem still exists? If so please report. I will perform an integration test to make sure normalized parsing does not cause this problem before I close this issue. Let me know before then or let me know so I can reopen this issue. Thanks.

[Alex Karasulu]

Could not isolate the problem. Somehow this issue was fixed with the changes made across releases. Please confirm if the problem persists.

[Emmanuel Lecharny]

Closing all issues created in 2005 and before which are marked resolved