class AbstractCoreTest should not be in core/src/main/java?

• Key: DIRSERVER-293
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Emmanuel Lecharny
• Affects Version/s: pre-1.0
• Fix Version/s: 1.0-RC1

Description

This is quite strange that the class AbstractCoreTest is found in apacheds/trunk/core/src/main/java/org/apache/ldap/server and not in apacheds/trunk/core/src/test/org/apache/ldap/server...

Comments

[Alex Karasulu]

Emmanuel this class is abstract for easily firing up the server and running unit tests. It's like ApacheDS-UNIT :). It is in the src dir as opposed to test because it is not a test and needs to be accessed from the outside world. Others testing new features with the server will use it.

Good catch regardless .. we have to be dilligent. Thanks Alex.

[Emmanuel Lecharny]

Even if this class is not a unit test per se, it's not either a part of the core ApacheDS program, so it may deserve a special place to be defined.

Is this just me? I'm reluctant to deliver a program which need to bundle junit.jar to be fully functional. I just saw it so many times, so ... (my 2cts)

[Alex Karasulu]

All great points. I will see if this can be taken care of after the release. Thanks for persevering ... at first I did not undertand exactly why you recommended this. We can create a apacheds-unit artifact just for those that wanna use an easy unit test that fires up the server to play.

[Alex Karasulu]

moved to core-unit

[Emmanuel Lecharny]

done