[#DIRSERVER-255] Adding a duplicate attribute value should cause an error.

Directory ApacheDS

Adding a duplicate attribute value should cause an error.

Created: 26/Sep/05 04:35 AM Updated: 10/Feb/06 12:26 PM

Return to search

Component/s:

None

Affects Version/s:

pre-1.0

Fix Version/s:

1.0-RC1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	ModifyAddDuplicateValueTest.java	2005-09-26 04:42 AM	Stefan Zoerner	6 kB

Resolution Date:

07/Jan/06 07:28 PM

Description

« Hide

Adding a duplicate attribute value to an entry with a single modify operation results in an invalid entry. After the operation it contains the parameter value twice. Hence someone is able to change this entry

dn: cn=Heather Nova,ou=system
objectClass: top
objectClass: person
cn: Heather Nova
sn: Nova

into an entry which looks like this:

dn: cn=Heather Nova,ou=system
objectClass: top
objectClass: person
objectClass: organizationalPerson
objectClass: organizationalPerson
cn: Heather Nova
sn: Nova

Expected behavior is LDAP Error code: 20 (Indicates that the attribute value specified in a modify or add operation already exists as a value for that attribute). This is quite similar to DIREVE-241 ("Adding an already existing attribute value with a modify operation does not cause an error."). But in this case, the attribute value is not present before, but is created with a single modify operation with two add changes. OK, it is a little bit bizarre, but other LDAP servers successfully refuse such an operation.

Find attached a test case with two tests, one for an already existing attribute type, and one for a new type (the issue arises in both occasions).

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Stefan Zoerner added a comment - 26/Sep/05 04:42 AM

Here is the test case for the described issue.

Stefan Zoerner made changes - 26/Sep/05 04:42 AM

Field	Original Value	New Value
Attachment		ModifyAddDuplicateValueTest.java [ 12314555 ]

Repository	Revision	Date	User	Message
ASF	#366701	Sat Jan 07 10:27:02 UTC 2006	akarasulu	fixed DIREVE-268 where duplicates in mods are not allowed - added tests and they pass now
				Files Changed
				MODIFY /directory/trunk/apacheds-server-unit/src/test/java/org/apache/ldap/server/ModifyAddTest.java MODIFY /directory/trunk/apacheds/src/main/java/org/apache/ldap/server/schema/SchemaService.java

[ Permlink | « Hide ]

Alex Karasulu added a comment - 07/Jan/06 07:28 PM

Committed fix and test cases (added to existing test case for ModifyAdd ops):

http://svn.apache.org/viewcvs?rev=366701&view=rev

Alex Karasulu made changes - 07/Jan/06 07:28 PM

Resolution		Fixed [ 1 ]
Fix Version/s		0.9.4 [ 12310230 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Stefan Zoerner added a comment - 11/Jan/06 01:06 AM

I have retested this one with a current 0.9.4 snapshot. Both situations described in the test cases worked as expected. Nice to see that, and in my role as the reporter, I close this issue: Click.

Stefan Zoerner made changes - 11/Jan/06 01:06 AM

Status

Resolved [ 5 ]

Closed [ 6 ]

Alex Karasulu made changes - 10/Feb/06 12:26 PM

Fix Version/s		1.0-RC1 [ 12310780 ]
Fix Version/s	1.0-RC1 [ 12310230 ]
Key	DIREVE-268	~~DIRSERVER-255~~
Affects Version/s	0.9.3 [ 12310193 ]
Affects Version/s		pre-1.0 [ 12310782 ]
Project	Directory Server [ 10516 ]	Directory ApacheDS [ 12310260 ]