Ldif parser does not accept comments

• Key: DIRSERVER-242
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Alex Karasulu
• Reporter: Emmanuel Lecharny
• Component/s: ldap
• Affects Version/s: pre-1.0
• Fix Version/s: pre-1.0

Description

LdifParserImpl class does not accept comments, as defined by RFC 2848, p.6, par. 3 :

try {
LdifParserImpl p = new LdifParserImpl();

LdifEntry entry = p.parse("#comment");

System.out.println(entry.toString());
} catch (Exception e) {
System.out.println(e.getMessage());
}

throws a LdapNamingException, with this message :

org.apache.ldap.common.exception.LdapNamingException: Line 0 [# empty file] does not correspond to an LDIF entry attribute value pair.
{# empty file}

I marked it Major even if a workaround could be to strip comments from ldif files, as many of them contain comments.

Comments

[Alex Karasulu]

Excellent find! These are the kinds of bug reports that you can't put a price tag on. I will add the entire trial of bugs to the 0.8.1 bug fix release and get to work on them immediately.

If you need to get at the sources SVN is the only option at the moment. This is because we did not have an external release of 0.8 ldap-common with the release of the server. The release we internal. Next time we should release all project to fix these issues people are having.

Great job Emmanuel - keep em comming!

Cheers,

Alex

Committed revision 232201 here:

http://svn.apache.org/viewcvs.cgi?rev=232201&view=rev

[Emmanuel Lecharny]

done