Refactor Attributes implementations

• Key: DIRSERVER-231
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Alex Karasulu
• Reporter: Trustin Lee
• Component/s: ldap
• Affects Version/s: pre-1.0
• Fix Version/s: pre-1.0

Description

There are a few implementations of JNDI Attributes type, but some of they seem to exist due to historical reason. Let's review and replace them with BasicAttributes if necessary.

Comments

[Alex Karasulu]

Not going to bother with this since our attributes impl works just fine and we have the code to change things if need be. We just need to cut out this Lockable object crap.

[Emmanuel Lecharny]

The specific LockableAttributeImpl class muts be refactored in two directions :
- as Alex said, 'Lockability' is useless.
- much more important, the class *must* be aware of it's attribute type. A user could perfectly store a String or a byte array in an attribute, depending on the attribute type being binary or not. Actually, it is supposed to be a String, and this is not the best option. We should accept byte[].

The following transformation table should be applied :

    Attribute's type client type server type
       String String String
       String byte[] String
       OctetString String byte[]
       OctetString byte[] byte[]
       whatever XXX error where XXX is not String or Byte