[#DIRSERVER-224] Overload SubtreeSpecificationParser constructor to take a NameComponentNormalizer

Directory ApacheDS

Overload SubtreeSpecificationParser constructor to take a NameComponentNormalizer

Created: 30/Aug/05 05:48 AM Updated: 07/Feb/06 02:41 PM

Return to search

Component/s:

ldap

Affects Version/s:

pre-1.0

Fix Version/s:

pre-1.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	NormalizingEnabledSubtreeSpecificationParser.patch	2005-08-31 07:49 PM	Ersin Er	6 kB

Resolution Date:

01/Sep/05 01:02 PM

Description

« Hide

The SubtreeSpecificationParser will need to normalize RDN values for exclusions. To do this it must delegate RDN normalization to the DnParser it uses. It must use the overloaded constructor on the DnParser which takes a NameComponentNormalizer as an argument. This means the SubtreeSpecificationParser's constructor must be overloaded to accept a NameComponentNormalizer to hand off to the DnParser constructor.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Alex Karasulu made changes - 30/Aug/05 05:49 AM

Field	Original Value	New Value
Component/s		Common [ 11085 ]

[ Permlink | « Hide ]

Ersin Er added a comment - 31/Aug/05 07:49 PM

The SubtreeSpecificationParser is now normalizing enabled (with the patch attached).

DnParser is instantiated in the antlr generated parser and antlr generated parsers' constructors are generally left as they are. So the code messed a bit to solve this tiny issue.

I've also added a test case for this new feature and it passes :-)

Ersin Er made changes - 31/Aug/05 07:49 PM

Attachment

NormalizingEnabledSubtreeSpecificationParser.patch [ 12312104 ]

Repository	Revision	Date	User	Message
ASF	#265643	Thu Sep 01 04:02:05 UTC 2005	akarasulu	Commiting patch from Ersin Er on DIRLDAP-50 here: http://issues.apache.org/jira/browse/DIRLDAP-50
				Files Changed
				MODIFY /directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/subtree/SubtreeSpecificationParser.java MODIFY /directory/shared/ldap/trunk/common/src/antlr/subtree-specification.g MODIFY /directory/shared/ldap/trunk/common/src/test/org/apache/ldap/common/subtree/SubtreeSpecificationParserTest.java

[ Permlink | « Hide ]

Alex Karasulu added a comment - 01/Sep/05 01:02 PM

Committed in revision 265643 here:

http://svn.apache.org/viewcvs.cgi?view=rev&rev=265643

Alex Karasulu made changes - 01/Sep/05 01:02 PM

Status	Open [ 1 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

Alex Karasulu made changes - 07/Feb/06 02:41 PM

Component/s	Common [ 11085 ]
Fix Version/s	0.9.3 [ 12310221 ]
Affects Version/s		pre-1.0 [ 12310782 ]
Type	Improvement [ 4 ]	Bug [ 1 ]
Key	DIRLDAP-50	~~DIRSERVER-224~~
Project	Directory LDAP [ 10514 ]	ApacheDS [ 12310260 ]
Fix Version/s		pre-1.0 [ 12310782 ]
Component/s		ldap [ 12310715 ]