Twix Support for LDAP Controls

• Key: DIRSERVER-185
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Emmanuel Lecharny
• Reporter: Van Nhu
• Affects Version/s: pre-1.0
• Fix Version/s: 1.5.0

Description

Please excuse my limited understanding of the LDAP Common source base, but it seems that the support for LDAP controls in the TwixTransformer is not complete. So I've made the following modifications to the LDAP Common module in order to have my Virtual Directory to correctly process the various LDAP controls:

1. Get the Twix Control class to implement the javax.naming.ldap.Control interface. Firstly, this is because Twix Controls are really LDAP Controls, and secondly, this makes it easier to create an org.apache.ldap.common.message.ControlImpl instance from a Twix Control object.

2. Remove the extraneous method declarations in org.apache.ldap.common.message.Control because they are already defined in javax.naming.ldap.Control

3. Fix a NullPointerException in org.apache.asn1new.ldap.pojo.LdapMessage.addControl() method

4. Implement the method org.apache.asn1new.ldap.TwixTransformer.transformControls() so that the Response Controls are propagated to the LDAP client properly.

The patch and the unit tests will be attached here shortly for your reference.

Thanks and Regards,
Van