Twix Support for LDAP Controls

• Key: DIRSERVER-185
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Emmanuel Lecharny
• Reporter: Van Nhu
• Affects Version/s: pre-1.0
• Fix Version/s: 1.5.0

Description

Please excuse my limited understanding of the LDAP Common source base, but it seems that the support for LDAP controls in the TwixTransformer is not complete. So I've made the following modifications to the LDAP Common module in order to have my Virtual Directory to correctly process the various LDAP controls:

1. Get the Twix Control class to implement the javax.naming.ldap.Control interface. Firstly, this is because Twix Controls are really LDAP Controls, and secondly, this makes it easier to create an org.apache.ldap.common.message.ControlImpl instance from a Twix Control object.

2. Remove the extraneous method declarations in org.apache.ldap.common.message.Control because they are already defined in javax.naming.ldap.Control

3. Fix a NullPointerException in org.apache.asn1new.ldap.pojo.LdapMessage.addControl() method

4. Implement the method org.apache.asn1new.ldap.TwixTransformer.transformControls() so that the Response Controls are propagated to the LDAP client properly.

The patch and the unit tests will be attached here shortly for your reference.

Thanks and Regards,
Van

Comments

[Van Nhu]

Add unit tests.

[Van Nhu]

A patch that implements the above-mentioned changes.

[Emmanuel Lecharny]

Thanks for the report !

You have to know that Twix is not already official (you can use it, but it's still beta) and that Snickers is the 'legacy' codec. Snacc will be 'terminated' soon.

so, on your points :

1) yes, this is a good idea.

2) ok, that's also a good idea

3) bloody hell ! a NPE... I have to double check the problem. I think that the init is not correct.

4) oopps. I commented this one for testing purpose, but I forgot to implemented it after having tested the code... My very bad !

Thanks to you Van !

-- Emmanuel Lécharny

[Emmanuel Lecharny]

The two last points have been fixed.

The two first are improvment, and they will be in the roadmap for 1.1.

So I consider that this is not an issue anymore, but an improvment.

Thanks again Van !

[Emmanuel Lecharny]

As I said, it as postponed for 1.1 release. So, right now, it's a work in progress :

 - the Control class has been renamed ControlImpl, and it implements the javax.naming.ldap.Control interface.
 - There will be no more twix or snickers implementation. Only a ADS implementation.

I guess that then your suggestion will be fullfiled :)

[Emmanuel Lecharny]

We will merge Twix and Snickers messages into a single set of classes. The idea would also be to create an API to help users who want to directly create clients for Ldap servers. It will be available for 1.1 or maybe 2.0

Closing all issues created in 2005 and before which are marked resolved