[#DIRMINA-95] Remove unnecessary checks on SessionBuffers in ThreadPoolFilters

MINA

Remove unnecessary checks on SessionBuffers in ThreadPoolFilters

Created: 17/Oct/05 09:35 AM Updated: 17/Oct/05 05:38 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

0.8.0

Time Tracking:

Not Specified

Resolution Date:

17/Oct/05 05:38 PM

Description

« Hide

BaseThreadPool.fetchBuffer checks if the fetched SessionBuffer is null or empty, and drops it if so. The problem here is 'what if it cannot be null or empty'. It might be better for us to remove this check code after some regression test.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#325860	Mon Oct 17 08:36:09 UTC 2005	trustin	Resolved issue: ~~DIRMINA-95~~ * Got rid of unnessary null/emptiness check * Renamed readySessionBuffers to unfetchedSessionBuffers * Renamed busySessionBuffers to allSessionBuffers
				Files Changed
				MODIFY /directory/network/branches/0.7/src/java/org/apache/mina/util/BaseThreadPool.java MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/ThreadPoolFilter.java

[ Permlink | « Hide ]

Trustin Lee added a comment - 17/Oct/05 05:36 PM

Removed unnecessary check code from the pool.

Trustin Lee made changes - 17/Oct/05 05:36 PM

Field	Original Value	New Value
Status	Open [ 1 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

Trustin Lee made changes - 17/Oct/05 05:38 PM

Status	Closed [ 6 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

[ Permlink | « Hide ]

Trustin Lee added a comment - 17/Oct/05 05:38 PM

Renamed the issue more properly

Trustin Lee made changes - 17/Oct/05 05:38 PM

Summary

We can move unnecessary checks on SessionBuffers in ThreadPoolFilters

Remove unnecessary checks on SessionBuffers in ThreadPoolFilters

Trustin Lee made changes - 17/Oct/05 05:38 PM

Status	Reopened [ 4 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]