Issue Details (XML | Word | Printable)

Key: DIRMINA-93
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Niklas Therning
Reporter: Trustin Lee
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MINA

Acceptor.unbind() doesn't disconnect connected clients.

Created: 30/Sep/05 11:43 AM   Updated: 23/Jan/06 12:07 PM
Return to search
Component/s: None
Affects Version/s: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4
Fix Version/s: 0.9.1

Time Tracking:
Not Specified

Issue Links:
Blocker
 

Resolution Date: 05/Jan/06 07:39 AM


 Description  « Hide
IoAcceptor currently doesn't disconnect connected clients and this will cause FD leakage and make clients stall because server is not responding at all.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #325869 Mon Oct 17 09:49:18 UTC 2005 trustin Resolving DIRMINA-93
* Changed the semantic of IoAcceptor.unbind(SocketAddress) to close all client connections
* Added IoAcceptor.unbind(SocketAddress,boolean) so that users can choose to close client connections
* Added BaseIoAcceptor to provide the default unbind(SocketAddress) implementation which calls unbind(SocketAddress, true)
* Fixed all compilation errors occurred due to the changes above
* Marked FIXMES because unbind() doesn't work properly yet
Files Changed
MODIFY /directory/network/trunk/src/java/org/apache/mina/transport/socket/nio/SocketAcceptor.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/transport/socket/nio/DatagramSessionManager.java
ADD /directory/network/trunk/src/java/org/apache/mina/common/BaseIoAcceptor.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoAcceptor.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/transport/vmpipe/VmPipeAcceptor.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/BaseIoSessionManager.java

Repository Revision Date User Message
ASF #366008 Wed Jan 04 22:26:52 UTC 2006 niklas Resolved DIRMINA-42 and DIRMINA-93. The IoAcceptors for socket and vmpipe
transports will now disconnect all clients by default on unbind.
Furthermore, the IoAcceptors for these transports also provide methods to
retrieve the currently connected sessions on a particular local address.
Neither of these features have been implemented for the datagram transport
since datagrams are connectionless and this kind of support doesn't make
much sense in that case.
Files Changed
ADD /directory/trunk/mina/src/test/java/org/apache/mina/transport/AbstractBindTest.java (from /directory/trunk/mina/src/test/java/org/apache/mina/transport/socket/nio/AbstractBindTest.java)
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/socket/nio/support/SocketConnectorDelegate.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeSessionImpl.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/common/support/DelegatedIoAcceptor.java
DEL /directory/trunk/mina/src/test/java/org/apache/mina/transport/socket/nio/AbstractBindTest.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipe.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/socket/nio/support/SocketIoProcessor.java
MODIFY /directory/trunk/mina/src/test/java/org/apache/mina/transport/socket/nio/DatagramBindTest.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/common/support/BaseIoAcceptor.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeFilterChain.java
ADD /directory/trunk/mina/src/test/java/org/apache/mina/transport/vmpipe/VmPipeBindTest.java
MODIFY /directory/trunk/mina/src/test/java/org/apache/mina/transport/socket/nio/SocketBindTest.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/common/IoAcceptor.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/vmpipe/VmPipeAcceptor.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/socket/nio/support/SocketAcceptorDelegate.java
MODIFY /directory/trunk/mina/src/main/java/org/apache/mina/transport/socket/nio/support/SocketSessionImpl.java