[#DIRMINA-85] SSLFilter race condition

MINA

SSLFilter race condition

Created: 01/Sep/05 08:46 PM Updated: 05/Dec/05 05:22 PM

Return to search

Component/s:

None

Affects Version/s:

0.9.0

Fix Version/s:

0.8.0

Time Tracking:

Not Specified

Environment:

Java 5, FC3 x86-64

Resolution Date:

14/Oct/05 01:12 AM

Description

« Hide

I'm facing a race condition in SSLFilter. Basically I've done a "STARTTLS" kind of implementation in which SSL is enabled over an existing plain-text connection. The server tells the client to start the SSL negotiation via the application protocol and puts an SSLFilter over the connection to handle the handshake.

The race condition occurs when the client sends the SSL handshake even before the SSLFilter is implemented on the connection. This data is sent to the IoHandler and causes all sorts of problems. Ultimately the session is in limbo - it has to be closed.

A solution would be to stall the processing of incoming/outgoing data on the session till the filter is implemented successfully.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Trustin Lee made changes - 02/Sep/05 12:44 AM

Field	Original Value	New Value
Link		This issue depends on ~~DIRMINA-2~~ [ ~~DIRMINA-2~~ ]

Repository	Revision	Date	User	Message
ASF	#320792	Thu Oct 13 16:09:18 UTC 2005	trustin	Fixed StartTLS race condition (~~DIRMINA-85~~) by providing an attribute key that disables encryption temporarilly.
				Files Changed
				MODIFY /directory/network/branches/0.7/src/java/org/apache/mina/io/filter/SSLFilter.java MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/SSLFilter.java

Trustin Lee made changes - 14/Oct/05 01:08 AM

Link

This issue depends on ~~DIRMINA-2~~ [ ~~DIRMINA-2~~ ]

[ Permlink | « Hide ]

Trustin Lee added a comment - 14/Oct/05 01:12 AM

We've discussed a lot on this issue and finally decided to use a session attribute key that temporarilly disables encryption:

http://www.nabble.com/-mina-SSLFilter-race-condition%3A-Take-2-t398500.html

Our discussion is not yet in the ASF official ML archive site, but you'll get to see it soon:

http://mail-archives.apache.org/mod_mbox/directory-dev/200510.mbox/browser

This fix applies to both 0.7 and 0.9 stream.

Trustin Lee made changes - 14/Oct/05 01:12 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
Fix Version/s		0.8 [ 11068 ]

Trustin Lee made changes - 14/Oct/05 01:12 AM

Comment

[ This issue depends on ~~DIRMINA-2~~. ]

[ Permlink | « Hide ]

Vinod Panicker added a comment - 05/Dec/05 05:22 PM

Works great.

Vinod Panicker made changes - 05/Dec/05 05:22 PM

Status

Resolved [ 5 ]

Closed [ 6 ]