SocketAcceptor needs to expose setReuseAddress()

• Key: DIRMINA-64
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Trustin Lee
• Reporter: Vinod Panicker
• Affects Version/s: 0.7.0, 0.7.1, 0.7.2
• Fix Version/s: 0.9.0

Description

The SocketAcceptor currently doesn't expose setReuseAddress() functionality. This is extremely necessary for server implementations. It would be great if a SocketAcceptor could expose a SocketSessionConfig type of class.

Comments

[Trustin Lee]

Should a 'setReuseAddress() call be invoked to ServerSocketChannel or SocketChannel? If it should be called to SocketChannel, doesn't calling Session.getConfig().setReuseAddress(true) in sessionCreated() work?

On the ServerSocketChannel. Taking an example where a server goes down for some reason, and an automated script tries to bring it back up again, the server needs to be able to bind to the same "well-known" port. If it is in TIME_WAIT state, as it most probably will be, the server will not be able to bind to the port unless setReuseAddress is set to true.

The client side implementation is fine.

[Trustin Lee]

Then what do you think about setting ReuseAddress to true by default and not providing any configurations?

[Vinod Panicker]

I'm OK with that w.r.t my current need, but it could cause certain problems due to negligence. eg - two instances of the server might be started by mistake and both would be getting data from the network. And keeping this as default might break someone's current implementation that depends on this being false. I'd suggest not changing default behavior - i.e. the standard JDK approach.

[Trustin Lee]

This issue has been resolved in 0.9 stream because the solution is not that simple to apply

[Trustin Lee]

Please close this issue if it is considered fixed.

[Vinod Panicker]

Meets the requirements. Thanks.