Issue Details (XML | Word | Printable)

Key: DIRMINA-40
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Trustin Lee
Reporter: Vinod Panicker
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MINA

Filter API needs callback for enabled notification

Created: 16/May/05 07:58 PM   Updated: 01/Dec/05 02:47 PM
Return to search
Component/s: None
Affects Version/s: 0.7.0, 0.7.1
Fix Version/s: 0.9.0

Time Tracking:
Not Specified

Environment: All

Resolution Date: 12/Jun/05 10:14 PM


 Description  « Hide
The Filter api currently assumes that it would be applied only on unopened sessions. Eg - the SSL filter currently starts its work on the sessionOpened() callback. This is an incorrect assumption since the SSL filter could be applied on an existing plain TCP connection as well.

It would be great if there were new callbacks defined - something like filterEnabled() and filterDisabled()

This would allow us to use the filters on existing sessions as well.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #190270 Sun Jun 12 13:11:30 UTC 2005 trustin Resolved: DIRMINA-40 Filter API needs callback for enabled notification
Files Changed
MODIFY /directory/network/trunk/src/test/org/apache/mina/common/IoFilterChainTest.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/LoggingFilter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/AbstractIoFilterChain.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoFilterAdapter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoSessionManagerFilterChain.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/ThreadPoolFilter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoFilter.java

Repository Revision Date User Message
ASF #328583 Wed Oct 26 07:48:44 UTC 2005 trustin Related issue: DIRMINA-40 - Filter API needs callback for enabled notification
* Renamed IoFilter.filterAdded() and filterRemoved() to init() and destroy() to avoid name confusion.
Files Changed
MODIFY /directory/network/trunk/src/test/org/apache/mina/common/IoFilterChainTest.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/LoggingFilter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoFilterChain.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/SSLFilter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoFilterAdapter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/support/AbstractIoFilterChain.java
MODIFY /directory/network/trunk/src/test/org/apache/mina/filter/ThreadPoolFilterRegressionTest.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/support/IoSessionManagerFilterChain.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/filter/ThreadPoolFilter.java
MODIFY /directory/network/trunk/src/java/org/apache/mina/common/IoFilter.java

Repository Revision Date User Message
ASF #350111 Thu Dec 01 02:45:48 UTC 2005 trustin Related issue: DIRMINA-40 Filter API needs callback for enabled notification
* Renamed init and destroy to onAdd and onRemove
* Added new init() and destroy() method which is invoked differently.
* Added IoFilterLifeCycleManager and extracted lifecycle control code from AbstractIoFilterChain
* Added IoFilterLifeCycleException; IoFilterChain now doesn't throw an Exception directly.
Files Changed
MODIFY /directory/network/branches/chain_refactor/src/test/org/apache/mina/filter/ThreadPoolFilterRegressionTest.java
ADD /directory/network/branches/chain_refactor/src/java/org/apache/mina/common/IoFilterLifeCycleException.java
MODIFY /directory/network/branches/chain_refactor/src/test/org/apache/mina/common/IoFilterChainTest.java
ADD /directory/network/branches/chain_refactor/src/java/org/apache/mina/common/support/IoFilterLifeCycleManager.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/filter/ThreadPoolFilter.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/filter/LoggingFilter.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/common/IoFilterChain.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/common/IoFilter.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/common/IoFilterAdapter.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/common/support/AbstractIoFilterChain.java
MODIFY /directory/network/branches/chain_refactor/src/java/org/apache/mina/filter/SSLFilter.java