[#DIRMINA-307] ReadThrottleFilterBuilder does not resume reading.

MINA

ReadThrottleFilterBuilder does not resume reading.

Created: 15/Nov/06 02:27 PM Updated: 28/Nov/06 11:57 AM

Return to search

Component/s:

Filter

Affects Version/s:

1.0.0

Fix Version/s:

1.0.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	ReadThrottleFilterBuilder.patch	2006-11-15 02:29 PM	Martin Ritchie	0.5 kB

Resolution Date:

28/Nov/06 01:03 AM

Description

« Hide

The starvation problems being experienced by testing of the MultiThreadedSocketIOProcessor(DIRMINA-301) are related to this bug.

When using multiple threads the the removeal of attribute SUSPENDED_READS is not done after resuming reads it is done on any and all calls to release.

The session.removeAttribute( SUSPENDED_READS ); line should be moved inside the if statement.

in method release:

           if( counter < maximumConnectionBufferSize && isSuspendedReads( session ) )
            {
                session.resumeRead();
                session.removeAttribute( SUSPENDED_READS );
            }

Patch is attached.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

No work has yet been logged on this issue.