Common internal messages that can be shared by filters and transport implementations

• Key: DIRMINA-166
• Type: Improvement
• Status: Open
• Priority: Minor
• Assignee: Unassigned
• Reporter: Alex Karasulu
• Affects Version/s: 0.9.0

Description

There are some common messages that can be shared by filters and transport implementations like in the SSL filter for handling secured and unsecured messages. Sometimes having this in the target requires JDK 1.5 dependency even if these features are not used. Here's a thread of converstation between Trustin and I about this speciifcially dealing with the SSLFilter and the LDAP protocol provider:

(21:19:02) trustin: StartTLS needs events that notify when the current session is secured or unsecured.
(21:19:14) trustin: SSLFilter emits them.
(21:19:21) akarasulu: right but can't we check the name of the class
(21:19:27) trustin: LDAP provider translates them into ExtendedMessage.
(21:19:46) trustin: We can do that.
(21:20:24) akarasulu: like message.getClass().equals( "org.apache.mina.filter.SSLFilter.SSLFilterMessage" );
(21:20:34) akarasulu: is this way bad?
(21:20:51) trustin: I think it's bad. We'd better define some core messages in mina-core.
(21:21:06) trustin: in... org.apache.mina.message.SessionSecured
(21:21:17) trustin: SessionUnsecured something like that.
(21:21:37) akarasulu: yeah that's better you're right

Comments

Might also be a good idea to create a ServiceUnbound message class to send to the IoHandler via the messageRecieved() handler method. This message can tell the handler that it must do something to active sessions before the service is unbound and all active sessions are automatically closed. This in combination with the mechanism introduced by Niklas might be useful for responding to unbinds.

I will use this to send a Notice of Disconnect to LDAP clients before shutting down all sessions.

[Alex Karasulu]

DIRMINA-166 will add a ServiceUnbound message that is to be delivered to he IoHandler via the messageRecieved() method. This will be used to iterate through the active sessions and send the NoD then close each session. We need to wait for this feauture before we can finish this one.

[Trustin Lee]

This issue is not urgent, so I'll schedule this issue later again.

[Emmanuel Lecharny]

Status for this issue ?