Name of threads created for Service ThreadPoolFilter aren't very revelant

• Key: DIRMINA-156
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Trustin Lee
• Reporter: Julien Vermillard
• Affects Version/s: 0.9.0
• Fix Version/s: 0.9.3

Description

all the threads created by the ThreadPoolFilters, added to Services by the SimpleServiceRegistry got the name "PoolThreadXXX".
a prefix with the service name whould be usefull for debuging or reading logs

Comments

[Trustin Lee]

The built-in thread pool in SimpleServiceRegistry is shared by multiple services, so we cannot set the service name. Of course we can call Thread.setName(String) whenever we process new session, but it will be quite expensive.

[Julien Vermillard]

a ThreadPool per service won't make sense ? so you can control threading per service ?

[Trustin Lee]

if you need more control over therad model, then you'd better use IoAcceptor directly IMHO. ServiceRegistry might be removed before we release 1.0 because we'll simplify the API so we don't need any frontend API anymore, so it makes sense considering current situation.

[Trustin Lee]

Will fix this in 0.9.3.

[Trustin Lee]

DIRMINA-190 resolves this issue. Please specify your own thread model like an example.