SocketAcceptor.bind() should fillInStackTrace() before rethrowing exception

• Key: DIRMINA-143
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Walter Tam
• Affects Version/s: 0.8.1
• Fix Version/s: 0.9.1

Description

When SocketAcceptor.bind() encounters an exception returned from the bind request, it simply rethrows. The resulting stack trace is from the underlying registration thread which is not very helpful when debugging the cause. Other similar places like SocketAcceptor.unbind(), DatagramAcceptor.unbind() does a fillInStackTrace() before re throwing.

Also it will be helpful in this case to add the port number that failed to the message

Comments

How about wrapping the original exception in a new IOException instead of using fillInStackTrace()? The message of the new exception would then indicate the port which couldn't be bound to. Or will that be too messy?

There might be a philosophy behind using fillInStackTrace() instead of wrapping? I usually prefer wrapping since then I won't miss out on any info that could be useful. Sometimes it can become very messy. In this case, however, I think it will be ok.

[Walter Tam]

Wrapping would be the logical choice. However in this case the IOException being thrown does not support wrapping. A possible solution is to throw a subclass of IOException with a constructor that takes a Throwable arguemnt.

[Trustin Lee]

I think it's not that messy. Good idea. What about creating our own exceptions which extends IOException and wrap throws exceptions?

[Trustin Lee]

We will fix it in MINA 0.9.1.

[Trustin Lee]

I checked in the fix.